Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ebs): Feature to create vm without snapshot #188

Closed
wants to merge 2 commits into from
Closed

feat(ebs): Feature to create vm without snapshot #188

wants to merge 2 commits into from

Conversation

lde
Copy link
Contributor

@lde lde commented Mar 27, 2024

Added a new flag on builder bsu to skip snapshot creation.
The goal to this feature is to be able to run provisioner(s) on ephemeral vm and destroy it without taking snapshot to run tests.
Flag name is skip_snapshot type boolean disabled by default.

The objective of this PR is to get a similar behavior of flag skip_create_ami on aws ebs builder.

@outscale-mgo
Copy link
Contributor

Hello,
thanks for the PR.
As Outscale API already have a resource named snapshot, skip_snapshot name is confusing as it seems related to snapshot API, where this is in fact simply skipping the whole image building.
So I would prefer a name like skip_create_omi.
Also, could you please use go fmt in your code, as the changes here builder/bsu/builder.hcl2spec.go seems to have a different formatting from other lines.
Again thanks for your PR.

@lde
Copy link
Contributor Author

lde commented Apr 2, 2024

Thanks for your feedback @outscale-mgo I renamed option, updated docs and lint code.
Let me know if you see an other thing to do.

@outscale-mgo
Copy link
Contributor

Hello,
Because of the way Packer CI work, the PR tests have to be run from an Outscale branch.
So I've tests it here: #189
I had to call make generate, but apart from that everything seems good.
I've merged your code by merging pr #189 (So I close this one).
Thanks again for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outscale-toa outscale-toa Awaiting requested review from outscale-toa outscale-toa is a code owner

@outscale-hmi outscale-hmi Awaiting requested review from outscale-hmi outscale-hmi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lde @outscale-mgo